Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CircularProgress] Accept as string size property #9700

Merged
merged 1 commit into from
Jan 2, 2018
Merged

[CircularProgress] Accept as string size property #9700

merged 1 commit into from
Jan 2, 2018

Conversation

jedwards1211
Copy link
Contributor

@jedwards1211 jedwards1211 commented Jan 2, 2018 •
edited by oliviertassinari
Loading

<CircularProgress size="1.2em" /> already works because "1.2em" gets passed straight into the style, this just gets rid of the PropTypes warning that size has to be a number.

Closes #9699

@oliviertassinari oliviertassinari self-assigned this Jan 2, 2018
@jedwards1211 @oliviertassinari
[CircularProgress] Accept as string size property
c32d401 
`<CircularProgress size="1.2em" />` already works because `"1.2em"` gets passed straight into the `style`, this just gets rid of the `PropTypes` warning that `size` has to be a `number`.
@oliviertassinari oliviertassinari changed the title fix: support string values for CircularProgress.size [CircularProgress] Accept as string size property Jan 2, 2018
@oliviertassinari oliviertassinari merged commit da62617 into mui:v1-beta Jan 2, 2018
@oliviertassinari oliviertassinari added the component: CircularProgress The React component label Jan 2, 2018
@oliviertassinari
Copy link
Member

@jedwards1211 Thank you!

@oliviertassinari oliviertassinari added the component: progress This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oliviertassinari oliviertassinari

Labels
component: CircularProgress The React component component: progress This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedwards1211 @oliviertassinari